[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

Shilei Tian via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 26 09:24:01 PST 2023


tianshilei1992 added a comment.

In D129008#4083185 <https://reviews.llvm.org/D129008#4083185>, @ABataev wrote:

> In D129008#4083150 <https://reviews.llvm.org/D129008#4083150>, @tianshilei1992 wrote:
>
>>> There are a bunch of places we do that for various language extensions already, including a bunch in the OpenMP code, and we usually just store the expression in the associated AST node.
>>
>> Could you please point me a rough location where we already have similar things such that I can learn and do the same thing for globalization? Thanks.
>
> You can check ActOnOpenMPFirstprivateClause, lines 18322-18353 (building of VDInitRefExpr)

Really appreciate that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129008/new/

https://reviews.llvm.org/D129008



More information about the cfe-commits mailing list