[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added a comment.

I'm not overly familiar with HLSL or DirectX here. Most of the changes are purely mechanical, but I don't see anywhere we create the tool. Does that come later? Normally you'd test these with `-ccc-print-bindings`, `-ccc-print-bindings`, and `-###`.



================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:146-147
+    // Not find dxv.
+    C.getDriver().Diag(diag::warn_drv_dxc_missing_dxv);
+    return;
+  }
----------------
Can we really just ignore this if we don't find the path? Normally this is a hard error. If this is purely optional I would probably suggest not creating the job in the first place.


================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:174
+    // Lookup binaries into the driver directory, this is used to
+    // discover the clang-offload-bundler executable.
+    getProgramPaths().push_back(getDriver().Dir);
----------------
Copy paste.


================
Comment at: clang/test/Misc/warning-flags.c:19
 
 The list of warnings below should NEVER grow.  It should gradually shrink to 0.
 
----------------
This comment looks relevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141705/new/

https://reviews.llvm.org/D141705