[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

A handful of suggestions as I spot-checked.  This looks great, thank you for doing this!  I'd like Aaron to take a look though.



================
Comment at: clang/docs/ReleaseNotes.rst:51
+- The ``-fexperimental-new-pass-manager`` and ``-fno-legacy-pass-manager``
+  flags have been removed. These have been no-ops since 15.0.0.
 
----------------
`no-ops` read awkwardly to me, so I'm hopeful that 'silently ignored' is a little more descriptive.

Perhaps, "deprecated and ignored" if that isn't accurate?


================
Comment at: clang/docs/ReleaseNotes.rst:53
 
-  Due to the extended period of time this bug was present in major C++
-  implementations (including Clang), this error has the ability to be
-  downgraded into a warning (via: ``-Wno-error=enum-constexpr-conversion``) to
-  provide a transition period for users. This diagnostic is expected to turn
-  into an error-only diagnostic in the next Clang release. Fixes
-  `Issue 50055 <https://github.com/llvm/llvm-project/issues/50055>`_.
+- Clang's resource dir used to include the full clang version. It will now
+  include only the major version. The new resource directory is
----------------



================
Comment at: clang/docs/ReleaseNotes.rst:54
+- Clang's resource dir used to include the full clang version. It will now
+  include only the major version. The new resource directory is
+  ``$prefix/lib/clang/$CLANG_MAJOR_VERSION`` and can be queried using
----------------



================
Comment at: clang/docs/ReleaseNotes.rst:170
+- Clang now diagnoses non-inline externally-visible definitions in C++
+  standard header units as per ``[module.import/6]``.  Previously, in Clang-15,
+  these definitions were allowed.  Note that such definitions are ODR
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142578/new/

https://reviews.llvm.org/D142578