[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

Lucas Prates via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 26 06:03:07 PST 2023


pratlucas marked an inline comment as done.
pratlucas added inline comments.


================
Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456
+  std::optional<AArch64::ExtensionInfo> Extension =
+      AArch64::parseArchExtension(ArchExt);
+  if (!Extension)
----------------
tmatheson wrote:
> I think we still need to test getDefaultExtensions, unless we're deleting it.
D142540 deletes it in favor of using the information in `CpuInfo` and `ArchInfo`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142539/new/

https://reviews.llvm.org/D142539



More information about the cfe-commits mailing list