[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.
Zahira Ammarguellat via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 26 05:41:25 PST 2023
zahiraam updated this revision to Diff 492410.
zahiraam marked 3 inline comments as done.
zahiraam edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142583/new/
https://reviews.llvm.org/D142583
Files:
clang/lib/Basic/Targets/SPIR.h
clang/test/CodeGen/arithmetic-fence-builtin.c
clang/test/Sema/arithmetic-fence-builtin.c
Index: clang/test/Sema/arithmetic-fence-builtin.c
===================================================================
--- clang/test/Sema/arithmetic-fence-builtin.c
+++ clang/test/Sema/arithmetic-fence-builtin.c
@@ -2,6 +2,7 @@
// RUN: %clang_cc1 -triple ppc64le -DPPC -emit-llvm -o - -verify -x c++ %s
// RUN: not %clang_cc1 -triple ppc64le -DPPC -emit-llvm -o - -x c++ %s \
// RUN: -fprotect-parens 2>&1 | FileCheck -check-prefix=PPC %s
+// RUN: %clang_cc1 -triple spir64 -emit-llvm -o - -verify -x c++ %s
#ifndef PPC
int v;
template <typename T> T addT(T a, T b) {
Index: clang/test/CodeGen/arithmetic-fence-builtin.c
===================================================================
--- clang/test/CodeGen/arithmetic-fence-builtin.c
+++ clang/test/CodeGen/arithmetic-fence-builtin.c
@@ -1,17 +1,22 @@
// Test with fast math
// RUN: %clang_cc1 -triple i386-pc-linux-gnu -emit-llvm -DFAST \
-// RUN: -mreassociate \
-// RUN: -o - %s | FileCheck --check-prefixes CHECK,CHECKFAST,CHECKNP %s
+// RUN: -mreassociate -o - %s \
+// RUN: | FileCheck --check-prefixes CHECK,CHECKFAST,CHECKPRECISE,CHECKNP %s
//
// Test with fast math and fprotect-parens
// RUN: %clang_cc1 -triple i386-pc-linux-gnu -emit-llvm -DFAST \
-// RUN: -mreassociate -fprotect-parens -ffp-contract=on\
-// RUN: -o - %s | FileCheck --check-prefixes CHECK,CHECKFAST,CHECKPP %s
+// RUN: -mreassociate -fprotect-parens -ffp-contract=on -o - %s \
+// RUN: | FileCheck --check-prefixes CHECK,CHECKFAST,CHECKPRECISE,CHECKPP %s
//
// Test without fast math: llvm intrinsic not created
// RUN: %clang_cc1 -triple i386-pc-linux-gnu -emit-llvm -fprotect-parens\
// RUN: -o - %s | FileCheck --implicit-check-not="llvm.arithmetic.fence" %s
//
+// Test with fast math on spir target
+// RUN: %clang_cc1 -triple spir64 -emit-llvm -mreassociate -o - %s \
+// RUN: | FileCheck --check-prefixes CHECK,CHECKFAST,CHECKNP %s
+//
+
int v;
int addit(float a, float b) {
// CHECK: define {{.*}}@addit(float noundef %a, float noundef %b) #0 {
@@ -65,7 +70,7 @@
#ifdef FAST
#pragma float_control(precise, on)
int subit(float a, float b, float *fp) {
- // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}}
+ // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}}
*fp = __arithmetic_fence(a - b);
*fp = (a + b);
// CHECK-NOT: call{{.*}} float @llvm.arithmetic.fence.f32(float noundef %add)
Index: clang/lib/Basic/Targets/SPIR.h
===================================================================
--- clang/lib/Basic/Targets/SPIR.h
+++ clang/lib/Basic/Targets/SPIR.h
@@ -191,6 +191,8 @@
bool hasFeature(StringRef Feature) const override {
return Feature == "spir";
}
+
+ bool checkArithmeticFenceSupported() const override { return true; }
};
class LLVM_LIBRARY_VISIBILITY SPIR32TargetInfo : public SPIRTargetInfo {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142583.492410.patch
Type: text/x-patch
Size: 2874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230126/91ee06a3/attachment.bin>
More information about the cfe-commits
mailing list