[PATCH] D142550: Fix sizeof of boolean vector
Mariya Podchishchaeva via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 26 02:00:19 PST 2023
Fznamznon updated this revision to Diff 492362.
Fznamznon added a comment.
Add more sizes to test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142550/new/
https://reviews.llvm.org/D142550
Files:
clang/lib/AST/ASTContext.cpp
clang/test/SemaCXX/vector-bool.cpp
Index: clang/test/SemaCXX/vector-bool.cpp
===================================================================
--- clang/test/SemaCXX/vector-bool.cpp
+++ clang/test/SemaCXX/vector-bool.cpp
@@ -90,3 +90,25 @@
foo(eight_bools.w); // expected-error at 90 {{illegal vector component name ''w''}}
foo(eight_bools.wyx); // expected-error at 91 {{illegal vector component name ''wyx''}}
}
+
+void Sizeof() {
+ using FourBools = bool __attribute__((ext_vector_type(4)));
+ using NineBools = bool __attribute__((ext_vector_type(9)));
+ using TwentyEightBools = bool __attribute__((ext_vector_type(28)));
+ using ThirtyThreeBools = bool __attribute__((ext_vector_type(33)));
+ using SixtyFiveBools = bool __attribute__((ext_vector_type(65)));
+ using Bool129 = bool __attribute__((ext_vector_type(129)));
+ using Bool150 = bool __attribute__((ext_vector_type(150)));
+ using Bool195 = bool __attribute__((ext_vector_type(195)));
+ using Bool257 = bool __attribute__((ext_vector_type(257)));
+ static_assert(sizeof(FourBools) == 1);
+ static_assert(sizeof(EightBools) == 1);
+ static_assert(sizeof(NineBools) == 2);
+ static_assert(sizeof(TwentyEightBools) == 4);
+ static_assert(sizeof(ThirtyThreeBools) == 8);
+ static_assert(sizeof(SixtyFiveBools) == 16);
+ static_assert(sizeof(Bool129) == 32);
+ static_assert(sizeof(Bool150) == 32);
+ static_assert(sizeof(Bool195) == 32);
+ static_assert(sizeof(Bool257) == 64);
+}
Index: clang/lib/AST/ASTContext.cpp
===================================================================
--- clang/lib/AST/ASTContext.cpp
+++ clang/lib/AST/ASTContext.cpp
@@ -2002,7 +2002,8 @@
TypeInfo EltInfo = getTypeInfo(VT->getElementType());
Width = VT->isExtVectorBoolType() ? VT->getNumElements()
: EltInfo.Width * VT->getNumElements();
- // Enforce at least byte alignment.
+ // Enforce at least byte size and alignment.
+ Width = std::max<unsigned>(8, Width);
Align = std::max<unsigned>(8, Width);
// If the alignment is not a power of 2, round up to the next power of 2.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142550.492362.patch
Type: text/x-patch
Size: 2084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230126/3ca805ac/attachment-0001.bin>
More information about the cfe-commits
mailing list