[PATCH] D129951: adds `__disable_adl` attribute

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 25 13:48:41 PST 2023


shafik added inline comments.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:542
 If a statement is marked ``nomerge`` and contains call expressions, those call
-expressions inside the statement will not be merged during optimization. This 
+expressions inside the statement will not be merged during optimization. This
 attribute can be used to prevent the optimizer from obscuring the source
----------------
A lot of these look like unrelated changes.


================
Comment at: clang/lib/Parse/ParseDecl.cpp:3788-3789
+      SourceLocation AttrNameLoc = Tok.getLocation();
+      DS.getAttributes().addNew(AttrName, AttrNameLoc, nullptr, AttrNameLoc,
+                                nullptr, 0, ParsedAttr::AS_Keyword);
+      break;
----------------



================
Comment at: clang/lib/Sema/SemaOverload.cpp:6514
         ND = SpecInfo->getTemplate();
-      
       if (ND->getFormalLinkage() == Linkage::InternalLinkage) {
----------------
Unrelated change?


================
Comment at: clang/lib/Sema/SemaOverload.cpp:13019
                                CandidateSet, PartialOverloading,
-                               /*KnownValid*/ true);
+                               /*KnownValid*/ true, ULE);
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129951/new/

https://reviews.llvm.org/D129951



More information about the cfe-commits mailing list