[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Wed Jan 25 11:02:55 PST 2023

Michael137 added a comment.

Latest diff now sets the `IsDefaulted` flag from `Sema::CheckTemplateArgumentList`, which is the best point I could find for creation of `TemplateArgument` which are fed into the various specialization decls (and later on the `TypePrinter`).

The review description has some additional info about the changes.

As a result of moving the `isSubstitutedDefaultArgument` higher up into `Sema`, we can simplify the other remaining callers:

- https://reviews.llvm.org/D141827
- https://reviews.llvm.org/D142333

Still unsure if changing the `TemplateArgument` constructors is cleaner than simply calling `setIsDefaulted` from the tablegen creators but I'm open to suggestions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141826/new/

https://reviews.llvm.org/D141826