[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

Dana Jansens via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 25 10:24:22 PST 2023


danakj added inline comments.


================
Comment at: clang/test/Index/annotate-comments-objc.m:121
 // CHECK: annotate-comments-objc.m:32:9: ObjCInstanceMethodDecl=method1_isdoxy4:{{.*}} method1_isdoxy4 IS_DOXYGEN_SINGLE
-// CHECK: annotate-comments-objc.m:43:22: EnumDecl=An_NS_ENUM_isdoxy1:{{.*}} An_NS_ENUM_isdoxy1 IS_DOXYGEN_SINGLE
 // CHECK: annotate-comments-objc.m:43:22: TypedefDecl=An_NS_ENUM_isdoxy1:{{.*}} An_NS_ENUM_isdoxy1 IS_DOXYGEN_SINGLE
----------------
danakj wrote:
> The comment is no longer attached to the enums generated by NS_ENUM, it is attached to the decl which is found in the text directly after the comment, which is the typedef, only.
Restored binding the comment outside the macro to the enums defined inside NS_ENUM() and NS_OPTIONS()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142560/new/

https://reviews.llvm.org/D142560



More information about the cfe-commits mailing list