[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

[Mark de Wever via Phabricator via cfe-commits]

Mordante added a comment.

In D142500#4080317 <https://reviews.llvm.org/D142500#4080317>, @erichkeane wrote:

> In D142500#4080302 <https://reviews.llvm.org/D142500#4080302>, @erichkeane wrote:
>
>> In D142500#4080279 <https://reviews.llvm.org/D142500#4080279>, @Mordante wrote:
>>
>>> In D142500#4079669 <https://reviews.llvm.org/D142500#4079669>, @erichkeane wrote:
>>>
>>>> In D142500#4079135 <https://reviews.llvm.org/D142500#4079135>, @Mordante wrote:
>>>>
>>>>> FYI I tested this patch with libc++ and as expected it does not fix the libc++ modular build ICE.
>>>>
>>>> A man can dream, eh?  Thank you for testing it!  I'm having troubles getting it reproduced unfortunately.
>>>
>>> Of course you can dream, and it would have been great if it had resolved the issue.
>>>
>>> Do you have trouble with libc++ or your hardware?
>>
>> I was having trouble with libc++ and the config.  The cmake you'd given me was either used poorly, or just didn't work.

:-(

> However, I was able to reproduce it with just the zip file you gave me.
>
> Woops, it wasn't you :)  It was @mstorsjo who gave me the zip file I can repro from :)

That's great!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142500/new/

https://reviews.llvm.org/D142500