[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

Lucas Prates via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 25 06:52:27 PST 2023


pratlucas created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
pratlucas requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald added projects: clang, LLVM.

This updates the parsing methods in AArch64's Target Parser to make use
of optional returns instead of "invalid" enum values, making the API's
behaviour clearer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142539

Files:
  clang/lib/Basic/Targets/AArch64.cpp
  clang/lib/Driver/ToolChains/Arch/AArch64.cpp
  llvm/include/llvm/TargetParser/AArch64TargetParser.h
  llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  llvm/lib/TargetParser/AArch64TargetParser.cpp
  llvm/unittests/TargetParser/TargetParserTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142539.492095.patch
Type: text/x-patch
Size: 28677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230125/c3d16c03/attachment-0001.bin>


More information about the cfe-commits mailing list