[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

[Luca Di sera via Phabricator via cfe-commits]

diseraluca reopened this revision.
diseraluca added a comment.
This revision is now accepted and ready to land.

When I pushed the patch the tests produced failures in buildbot. 
I reverted the patch as I did not have the time to check what was happening.

I've now had time to check and the failures seems to be due to the implementation dependent signed-ness of char, 
thus failing on platforms where char is unsigned (like power pc).

I've changed the tests to use a more precise unsigned char which should solve the issue.
There is probably a way to only check for the presence or lack thereof of the (explicit) tag without checking those unimportant details, 
but I had not time to accustom myself to FileCheck yet.

I reopened the revision to have a second set of eyes check this as I would really like to avoid blocking the integrations again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140756/new/

https://reviews.llvm.org/D140756