[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

Tue Jan 24 20:45:10 PST 2023

carlosgalvezp added inline comments.

================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1
+// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- -- -fno-delayed-template-parsing
+
----------------
ccotter wrote:
> ccotter wrote:
> > carlosgalvezp wrote:
> > > You specified C++11 in the LangOpts, but test against C++14 or later in the test, maybe change it here to c++11-or-later?
> > The test uses generalize lambda capture, so it needs 14. Should I split the tests that use C++14 features to a separate file, and update this test file to use 11?
> Ah, and use of `auto` parameters in other lambdas. So there are a few tests that would need to be split out to a separate file, use an `ifdef __cplusplus` check (I see one other cppcoreguidelines test does this).
Oops I forgot to submit my comment. Yes I think we could keep everything in one test file running `c++11-or-later`, and `#ifdef` the C++14 parts.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141569/new/

https://reviews.llvm.org/D141569