[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 24 13:13:12 PST 2023


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/test/ClangScanDeps/modules-implementation-vfs.m:67-68
+#import <B/B.h>
+struct A { float x; }; // expected-error {{incompatible definitions}} expected-note {{type 'float' here}}
+// expected-note at frameworks/A.framework/Headers/A.h:1 {{type 'int' here}}
+
----------------
benlangmuir wrote:
> jansvoboda11 wrote:
> > What purpose does this check serve?
> Added a comment to explain this check.
Makes sense now, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142501/new/

https://reviews.llvm.org/D142501



More information about the cfe-commits mailing list