[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 24 10:31:49 PST 2023


tra added inline comments.


================
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491
           new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false,
-                             llvm::Align(Var->getAlignment()), I);
+                             Var->getAlign().valueOrOne(), I);
       WorkItem.pop_back();
----------------
This appears to be a change in behavior. AFAICT, previously used Var->getAlignment() could return alignment value or 0. Now it's value or 1.

Is it intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142459/new/

https://reviews.llvm.org/D142459



More information about the cfe-commits mailing list