[PATCH] D142468: [clang][dataflow] Fix bug in handling of reference-typed fields.

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel marked an inline comment as done.
ymandel added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:209
     if (VD->getType()->isReferenceType()) {
+      assert(isValidReferenceLoc(*DeclLoc, Env) &&
+             "reference-typed declarations map to `ReferenceValue`s");
----------------
sgatev wrote:
> Can we use `isa_and_nonnull(Env.getValue(Loc))` instead?
Yes, much better. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142468/new/

https://reviews.llvm.org/D142468