[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

Timm B├Ąder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 24 00:29:57 PST 2023


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:727-728
+    this->emitSubOffset(*RT, E);
+  else
+    return false;
+
----------------
aaron.ballman wrote:
> Should this be an early return before we visit anything? Or an assert on the assumption that we should only get here for `+=` and `-=`?
Sure, that would work as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140874/new/

https://reviews.llvm.org/D140874



More information about the cfe-commits mailing list