[PATCH] D138546: Clangd: Preserve target flags in system includes extractor
Christopher Sauer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 23 19:38:48 PST 2023
cpsauer added a comment.
Yay. Thanks, Nathan, for guiding, replying, and just generally being so kind, great, and thorough.
I'll back out the plugin part of the changes changes momentarily, then.
Just to confirm: Sounds like you're not concerned, then, that the JSONCompilationDatabasePlugin will get invoked and the results then passed to a SystemIncludeExtractor-enabled mangler?
(I'd seen some fallback calls into the plugin registry in GlobalCompilationDatabase, hence the original change, but, lacking broader context, I was having trouble tracing the expected control flow.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138546/new/
https://reviews.llvm.org/D138546
More information about the cfe-commits
mailing list