[PATCH] D142416: [clang][deps] NFC: Remove dead code

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added a comment.

Removing `ImplicitModulePCMPath` LGTM; not sure about the other change.



================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180
-  // incompatible modules (e.g. with differences in search paths).
-  CI.getHeaderSearchOpts().ModulesStrictContextHash = true;
-
----------------
I see we're enabling strict hashing in the scaner itself: `ScanInstance.getHeaderSearchOpts().ModulesStrictContextHash = true;`, which makes me think this code was never used to influence the scanner's implicit build.  If that's true, was this code *already* dead before my change in D129884?  It's not clear to me what it was doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142416/new/

https://reviews.llvm.org/D142416