[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 23 15:51:10 PST 2023
aaronpuchert added inline comments.
================
Comment at: flang/lib/Frontend/FrontendActions.cpp:590
+ std::optional<llvm::CodeGenOpt::Level> OptLevelOrNone =
+ CodeGenOpt::getLevel(CGOpts.OptimizationLevel);
+ assert(OptLevelOrNone && "Invalid optimization level!");
----------------
Does this need `llvm::`?
```
../llvm-project/flang/lib/Frontend/FrontendActions.cpp:590:7: error: use of undeclared identifier 'CodeGenOpt'; did you mean 'llvm::CodeGenOpt'?
CodeGenOpt::getLevel(CGOpts.OptimizationLevel);
^~~~~~~~~~
llvm::CodeGenOpt
../llvm-project/llvm/include/llvm/Support/CodeGen.h:53:13: note: 'llvm::CodeGenOpt' declared here
namespace CodeGenOpt {
^
```
See https://lab.llvm.org/buildbot/#/builders/191/builds/13832.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141968/new/
https://reviews.llvm.org/D141968
More information about the cfe-commits
mailing list