[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 12:49:30 PST 2023


carlosgalvezp added a comment.

In D140434#4073212 <https://reviews.llvm.org/D140434#4073212>, @ymandel wrote:

> In D140434#4071823 <https://reviews.llvm.org/D140434#4071823>, @carlosgalvezp wrote:
>
>> In D140434#4053053 <https://reviews.llvm.org/D140434#4053053>, @suertreus wrote:
>>
>>> Thanks for reviewing.
>>>
>>> I don't have commit access; can someone who does please do the thing?
>>
>> @suertreus I can help you land the patch, what user name and email should I use for attribution?
>
> Sorry for the delay -- I'm doing the commit now (just running tests first)

Sounds good, I'll leave you to it :) Let me know otherwise if you need help!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140434/new/

https://reviews.llvm.org/D140434



More information about the cfe-commits mailing list