[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 09:41:14 PST 2023


nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/Hover.cpp:1030
+      } else {
+        if (CD->getNumParams() == 1)
+          PassType.PassBy = getPassMode(CD->getParamDecl(0)->getType());
----------------
This check should be `>= 1`, since the constructor could have additional parameters that have default arguments and still be used for implicit conversion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142014/new/

https://reviews.llvm.org/D142014



More information about the cfe-commits mailing list