[PATCH] D142315: [clang] Add test for CWG1111

Vlad Serebrennikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 08:04:44 PST 2023


Endill added inline comments.


================
Comment at: clang/www/cxx_dr_status.html:6476
     <td>Remove dual-scope lookup of member template names</td>
-    <td class="none" align="center">Unknown</td>
+    <td class="full" align="center">Clang 6</td>
   </tr>
----------------
shafik wrote:
> aaron.ballman wrote:
> > erichkeane wrote:
> > > Were you able to track down which patch fixed this in clang 6?
> > > 
> > > I also don't think we can mark this as 'full' support, if its still broken in C++98.  Unless we can find a good reason this wasn't/wont be done for C++98 as well, I don't know if we can mark this as 'done'.
> > We can mark it as `partial` and put the reason in the details. I'm not certain if the python script has a way to do that easily or not.
> I think this might be related as well: https://github.com/llvm/llvm-project/issues/59910
> Were you able to track down which patch fixed this in clang 6?
I haven't even tried, since I don't intend to fix this for now.

> We can mark it as partial and put the reason in the details.
Is false-positive //warning// enough to degrade `full` to `partial` despite the correct behavior? Just confirming here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142315/new/

https://reviews.llvm.org/D142315



More information about the cfe-commits mailing list