[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

Luís Marques via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 07:33:56 PST 2023


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM but others should also chime in.



================
Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:101
+
+struct s5 { struct empty e[1]; float f; };
+
----------------
Should we also test a case with an array size 0 like `ct s { struct empty e[0]; float f; };`? I think that's a GNU extension and I don't expect the result to be different but...



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142326/new/

https://reviews.llvm.org/D142326



More information about the cfe-commits mailing list