[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

[Sam Elliott via Phabricator via cfe-commits]

lenary added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:8297
              << Arg->getSourceRange();
   } else if (IsAArch64Builtin && Fields.size() == 1) {
+    // If this is a write ...
----------------
tmatheson wrote:
> It might be more readable to outline this whole branch and remove the redundant "else".
Sorry, this is not done, but I'm not sure that fundamentally helps this very long function doing too many different things be more readable. I'm going to land this today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140222/new/

https://reviews.llvm.org/D140222