[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

Kacper Kowalski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 05:52:15 PST 2023


KKoovalsky updated this revision to Diff 491331.
KKoovalsky added a comment.

1. Fixed lit fail: dereferencing a null pointer when calling `ignoreImplicit()` on `CommonAncestor` being `nullptr` - fixed with sanitization of `CommonAncestor` being `nullptr`.
2. Fixed link error: missing `ASTMatchers` lib.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140619/new/

https://reviews.llvm.org/D140619

Files:
  clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp
  clang-tools-extra/clangd/tool/CMakeLists.txt
  clang-tools-extra/clangd/unittests/tweaks/ExtractFunctionTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140619.491331.patch
Type: text/x-patch
Size: 44213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230123/eeee2cab/attachment-0001.bin>


More information about the cfe-commits mailing list