[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

Mon Jan 23 03:54:33 PST 2023

mgorny added a comment.

In D141581#4072692 <https://reviews.llvm.org/D141581#4072692>, @kwk wrote:

> In D141581#4071617 <https://reviews.llvm.org/D141581#4071617>, @thesamesam wrote:
>
>> This is currently holding back further testing on our end which is concerning me a bit, especially as we approach the branch point. Could you revert this please if a fix isn't imminent? Thank you!
>
> @thesamesam what do you mean with "revert"? Just by looking at this differential I cannot see that this patch has landed. Has it?

He was referring to reverting ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf <https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf>, i.e. the change that introduced the problem. However, FWICS reverting it is non-trivial and will probably cause quite a mess.

So, well, we're stuck for two weeks now being unable to test new LLVM versions, the branching point is approaching fast and it's quite likely we'll have to put a lot of effort afterwards to fix everything and request backporting our fixes to 16.x.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141581/new/

https://reviews.llvm.org/D141581