[PATCH] D142125: [clang] Fix the location of UsingTypeLoc.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 03:53:53 PST 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGebbeb164c25a: [clang] Fix the location of UsingTypeLoc. (authored by hokein).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142125/new/

https://reviews.llvm.org/D142125

Files:
  clang-tools-extra/clangd/unittests/SelectionTests.cpp
  clang/lib/Sema/SemaType.cpp


Index: clang/lib/Sema/SemaType.cpp
===================================================================
--- clang/lib/Sema/SemaType.cpp
+++ clang/lib/Sema/SemaType.cpp
@@ -6256,6 +6256,9 @@
     void VisitTagTypeLoc(TagTypeLoc TL) {
       TL.setNameLoc(DS.getTypeSpecTypeNameLoc());
     }
+    void VisitUsingTypeLoc(UsingTypeLoc TL) {
+      TL.setNameLoc(DS.getTypeSpecTypeNameLoc());
+    }
     void VisitAtomicTypeLoc(AtomicTypeLoc TL) {
       // An AtomicTypeLoc can come from either an _Atomic(...) type specifier
       // or an _Atomic qualifier.
Index: clang-tools-extra/clangd/unittests/SelectionTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/SelectionTests.cpp
+++ clang-tools-extra/clangd/unittests/SelectionTests.cpp
@@ -520,6 +520,13 @@
       )cpp",
        "TypedefTypeLoc"},
 
+      {R"cpp(
+        namespace ns { class Foo {}; }
+        using ns::Foo;
+        class [[^Foo]] foo;
+      )cpp",
+       "UsingTypeLoc"},
+
       // lambda captured var-decl
       {R"cpp(
         void test(int bar) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142125.491291.patch
Type: text/x-patch
Size: 1096 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230123/7bd8cd08/attachment-0001.bin>


More information about the cfe-commits mailing list