[PATCH] D139326: [clang] Add test for CWG952

Vlad Serebrennikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 02:20:45 PST 2023


Endill added inline comments.


================
Comment at: clang/test/CXX/drs/dr9xx.cpp:76
+namespace dr952 { // dr952: yes
+struct A {
+  typedef int I; // #dr952-typedef-decl
----------------
aaron.ballman wrote:
> I wouldn't mind another test case:
> ```
> struct A {
> protected:
>   static int x;
> };
> struct B : A {
>   friend int get(B) { return x; }
> };
> ```
> this was something Richard had pointed out needs to still work as part of the reflector discussions of this issue.
Sorry, it seems I missed your comment when I landed the patch. Would it be fine to add this test as NFC patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139326/new/

https://reviews.llvm.org/D139326



More information about the cfe-commits mailing list