[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:19
+
+namespace clang {
+namespace tidy {
----------------
ccotter wrote:
> carlosgalvezp wrote:
> > We recently switched to using C++17 nested namespaces for all the clang-tidy folder, please update to keep it consistent.
> Just curious - I noticed the clang-tidy headers do not use nested namespaces as part of the recent switch. Are the headers slated to be updated too?
Oh crap, I must have missed to add the `header-filter` option when applying the change, it should apply to headers as well! Will fix in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141133/new/

https://reviews.llvm.org/D141133