[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include
WÁNG Xuěruì via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jan 22 00:58:05 PST 2023
xen0n added inline comments.
================
Comment at: clang/bindings/python/tests/cindex/util.py:82
+# our tests.
+os.environ["CLANG_NO_DEFAULT_CONFIG"] = "1"
----------------
This is essentially an import-time side effect, IMO it could be better to instead put the envvar provision in `clang/bindings/python/tests/CMakeLists.txt`: the `add_custom_target` there already is making use of `env` so should be relatively easy to stuff this there too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141248/new/
https://reviews.llvm.org/D141248
More information about the cfe-commits
mailing list