[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

[Kyle Edwards via Phabricator via cfe-commits]

KyleFromKitware added a comment.

In D142123#4071099 <https://reviews.llvm.org/D142123#4071099>, @njames93 wrote:

> Can you just elaborate on what the registry is used for? Is the plan to support potentially dynamically loading `HeaderGuardStyle` classes.

Yes.

> If thats the case, Then I'd argue we don't need the `HeaderGuardBase` check class, We can just create a `HeaderGuardCheck` class that creates an instance of the `HeaderGuardStyle` based on the configuration options.

Yes, that was my plan, sorry for not making that explicit. `HeaderGuardStyle` is supposed to be analogous to `HeaderGuardBase` and `MacroHeaderGuardStyle` is supposed to be analogous to `HeaderGuardCheck` from D142121 <https://reviews.llvm.org/D142121>.

> Then to maintain backwards compatibility the `llvm-header-guard` could be an alias with the default style option set to `llvm` for example.

Sounds good. What should the default for regular `header-guard` be then?

> Also this goes for all your PRs, can you please upload them in future with full context `git diff -U999999` should do it. Makes revewing changes easier and removes those `Context not available` message on phab

Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142123/new/

https://reviews.llvm.org/D142123