[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 21 06:38:43 PST 2023


njames93 added a comment.

Can you just elaborate on what the registry is used for? Is the plan to support potentially dynamically loading `HeaderGuardStyle` classes.
If thats the case, Then I'd argue we don't need the `HeaderGuardBase` check class, We can just create a `HeaderGuardCheck` class that creates an instance of the `HeaderGuardStyle` based on the configuration options.
Then to maintain backwards compatibility the `llvm-header-guard` could be an alias with the default style option set to `llvm` for example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142123/new/

https://reviews.llvm.org/D142123



More information about the cfe-commits mailing list