[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

[Nathan Ridge via Phabricator via cfe-commits]

nridge added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:15186
+      if (ChildExpr == CSE->getOperand())
+        // Do not recurse over a CoroutineSuspendExpr's operand.
+        // The operand is also a subexpression of getCommonExpr(), and
----------------
Out of curiosity, since `getCommonExpr()` is itself a subexpression of `getReadyExpr()`, `getSuspendExpr()`, and `getResumeExpr()` (which are also children of the `CoroutineSuspendExpr`), shouldn't `getCommonExpr()` be skipped for the same reason?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142077/new/

https://reviews.llvm.org/D142077