[PATCH] D140972: [flang] Add -fstack-arrays flag

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 20 11:07:11 PST 2023


awarzynski added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:485-486
 
+// Works like BoolOption except without specifying a KeyPathAndMacro, as these
+// would refer to non-existant members of clang data structures
+multiclass BoolFlangOnlyOption<string prefix = "", string spelling_base,
----------------
[nit] To me `KeyPathAndMacro` is just an implementation detail. The key part is that `BoolOption` does use the marshaling infra and `BoolFlangOnlyOption` does not. Perhaps rename as `BoolOptionWithoutMarshalling`? There isn't anything Flang specific here, is there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140972/new/

https://reviews.llvm.org/D140972



More information about the cfe-commits mailing list