[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

Francesco Petrogalli via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 20 08:05:01 PST 2023


fpetrogalli added a comment.

In D141581#4069123 <https://reviews.llvm.org/D141581#4069123>, @tstellar wrote:

> I don't think this is the correct way to specify dependencies if it's just an issue of the header being included before a generated file it needs has been generated.  Are there other places in the code where a generated header file is included by another header?



  % grep -r "RISCVTargetParser.h" *
  include/llvm/module.modulemap:    header "TargetParser/RISCVTargetParser.h"
  lib/Target/RISCV/RISCVISelLowering.h:#include "llvm/TargetParser/RISCVTargetParser.h"
  lib/TargetParser/RISCVTargetParser.cpp:#include "llvm/TargetParser/RISCVTargetParser.h"

`RISCVTargetParser.h` is the one that references the generated file via :

  enum CPUKind : unsigned {
  #define PROC(ENUM, NAME, FEATURES, DEFAULT_MARCH) CK_##ENUM,
  #define TUNE_PROC(ENUM, NAME) CK_##ENUM,
  #include "llvm/TargetParser/RISCVTargetParserDef.inc"
  };


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141581/new/

https://reviews.llvm.org/D141581



More information about the cfe-commits mailing list