[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

Fri Jan 20 07:45:53 PST 2023

tstellar added a comment.

Is LLVMTargetParser a library

In D141581#4057177 <https://reviews.llvm.org/D141581#4057177>, @fpetrogalli wrote:

> In D141581#4056825 <https://reviews.llvm.org/D141581#4056825>, @barannikov88 wrote:
>
>> clangBasic and clangDriver already have a dependency on TargetParser (see LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not enough?
>> Will it build if you just remove the additional dependency?
>
> No - if we just specify the dependency in `LLVM_LINK_COMPONENTS`, there are build failures, as explained in the commit message of https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf.

It's still not clear to me why LLVM_LINK_COMPONENTS does not work.  Is LLVMTargetParser a library?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141581/new/

https://reviews.llvm.org/D141581