[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added a comment.

In D142033#4062671 <https://reviews.llvm.org/D142033#4062671>, @bader wrote:

> Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to validate function attributes other than `convergent`? It's not obvious that presence of `nounwind` attribute is validated by `clang/test/CodeGenOpenCL/convergent.cl`.

I think the main goal of `clang/test/CodeGenOpenCL/convergent.cl` remains testing `convergent`, so I'd rather not generalize this particular test.  `nounwind` is somewhat coincidentally tested by various tests now, but we could add a separate test for generic attributes such as `nounwind` if you think it's worth doing so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142033/new/

https://reviews.llvm.org/D142033