[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

[Nikita Popov via Phabricator via cfe-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. The task-clock improvement is likely noise, but there's definitely a code size / max-rss win here.



================
Comment at: clang/include/clang/Basic/BuiltinHeaders.def:9
+//
+// This file defines the standard builtin function header locations.  Users of this file
+// must define the HEADER macro to make use of this information.
----------------
Probably overlong line?


================
Comment at: clang/include/clang/Basic/Builtins.h:68
+    };
+  }
+};
----------------
It might make more sense to define this out of line in a C++ file. (Doesn't seem performance critical, and probably generates a bunch of redundant strings and a lookup table in each object file...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142024/new/

https://reviews.llvm.org/D142024