[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

Elena Lepilkina via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 23:48:21 PST 2023


eklepilkina added a comment.

> How does this affect LTO?

This problem appeared only under lto as far as it's processed as one module.

> Is this not just one of many symptoms of RISC-V not having the right module-level subtarget under LTO, which is a real problem that needs fixing?

Not exactly, to build right subtarget we need attributes. As far as mentioned in comments in code the main approach to provide subtarget information is adding information in functions attributes. Why not to provide this information for runtime functions? If we don't have right attributes what shall we use to find out proper target features?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139704/new/

https://reviews.llvm.org/D139704



More information about the cfe-commits mailing list