[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:1
+//===--- AvoidCaptureDefaultWhenCapturingThisCheck.cpp - clang-tidy
+//---------===//
----------------
Ditto.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.h:1
+//===--- AvoidCaptureDefaultWhenCapturingThisCheck.h - clang-tidy *- C++
+//-*-===//
----------------
Please merge these two lines. Amount of dashes and equal signs could be reduced.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:117
+
+  Warns when lambda specify a capture default and capture ``this``. The check also
+  offers fix-its.
----------------
`The check also offers fix-its.` could be omitted. This information presents in check table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141133/new/

https://reviews.llvm.org/D141133