[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

I've confirmed that this breaks a pretty vanilla build setup.

  /Applications/CMake.app/Contents/bin/cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS='clang;compiler-rt;clang-tools-extra;lld' -DLLVM_APPEND_VC_REV=NO -DLLVM_TARGETS_TO_BUILD='X86' -DCMAKE_C_COMPILER=$PWD/../llvm-project/out/gn/bin/clang -DCMAKE_CXX_COMPILER=$PWD/../llvm-project/out/gn/bin/clang++ -DCMAKE_OSX_SYSROOT=$HOME/llvm-project/sysroot/MacOSX.sdk -DDARWIN_macosx_CACHED_SYSROOT=$HOME/src/llvm-project/sysroot/MacOSX.sdk -DDARWIN_iphoneos_CACHED_SYSROOT=$HOME/src/llvm-project/sysroot/iPhoneOS.sdk -DDARWIN_iphonesimulator_CACHED_SYSROOT=$HOME/src/llvm-project/sysroot/iPhoneSimulator.sdk ../llvm-project/llvm
  
  % time caffeinate ninja check-clang
  ...
    Clang :: Driver/arc.c
    Clang :: Driver/clang-g-opts.c
    Clang :: Driver/clang-translation.c
    Clang :: Driver/darwin-debug-flags.c
    Clang :: Driver/darwin-header-search-system.cpp
    Clang :: Driver/darwin-ld-platform-version-macos.c
    Clang :: Driver/darwin-ld.c
    Clang :: Driver/darwin-multiarch-arm.c
    Clang :: Driver/darwin-objc-options.m
    Clang :: Driver/darwin-version.c
    Clang :: Driver/debug-options.c
    Clang :: Driver/fsanitize.c
    Clang :: Driver/macos-apple-silicon-slice-link-libs.cpp
    Clang :: Driver/target-triple-deployment.c

This is on macOS 13.1.

(sysroot dir created via ` llvm/utils/sysroot.py make-fake --out-dir sysroot`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136315/new/

https://reviews.llvm.org/D136315