[PATCH] D142118: [HIP] Unbundler allows missing host entry

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/OffloadBundler.cpp:1063
   // in case host bundle name was provided in command line.
-  if (!FoundHostBundle && BundlerConfig.HostInputIndex != ~0u)
+  if (!FoundHostBundle && BundlerConfig.HostInputIndex != ~0u && !BundlerConfig.AllowMissingBundles)
     return createStringError(inconvertibleErrorCode(),
----------------
tra wrote:
> Nit: My usual pet peeve - too many negations. 
> 
> `if (!(FoundHostBundle || BundlerConfig.HostInputIndex == ~0u || BundlerConfig.AllowMissingBundles)))` is easier to understand, IMO.
will fix when committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142118/new/

https://reviews.llvm.org/D142118