[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

Thu Jan 19 11:45:45 PST 2023

fahadnayyar marked 3 inline comments as done.
fahadnayyar added a comment.

In D141868#4060757 <https://reviews.llvm.org/D141868#4060757>, @NoQ wrote:

> Looks great! Sounds like you're looking for a more permanent fix, I guess `ConversionFixItGenerator` could try to avoid adding fixits to system header functions?

It probably requires some larger rearchitecturing of the FixItGeneration implementation to avoid system headers for all kinds of FixitHints like `ConversionFixIt`. We can do that later as a separate patch after getting some more examples where fixits are suggested for system headers.

In D141868#4065287 <https://reviews.llvm.org/D141868#4065287>, @aaron.ballman wrote:

> You should also add a release note for the changes.

Done!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141868/new/

https://reviews.llvm.org/D141868