[PATCH] D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 11:31:08 PST 2023


benlangmuir added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:4415
+    if (Result.isNot(tok::header_name))
+      return true;
+    // Advance the index of lexed tokens.
----------------
This case is missing a test I think.


================
Comment at: clang/lib/Lex/Lexer.cpp:4420
+          DepDirectives.front().Tokens[NextDepDirectiveTokenIndex];
+      if (BufferStart + NextTok.Offset >= BufferPtr)
+        break;
----------------
How do we know this will terminate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142143/new/

https://reviews.llvm.org/D142143



More information about the cfe-commits mailing list