[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

Kyle Edwards via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 10:30:48 PST 2023


KyleFromKitware added a comment.

In D142123#4066460 <https://reviews.llvm.org/D142123#4066460>, @aaron.ballman wrote:

> In D142123#4066447 <https://reviews.llvm.org/D142123#4066447>, @lebedev.ri wrote:
>
>> In D142123#4066351 <https://reviews.llvm.org/D142123#4066351>, @njames93 wrote:
>>
>>> 
>
> We're trying to figure out what the correct approach is (fwiw, I'd be opposed to what's proposed as-is but would be fine with a tweaked proposal).

Thanks for clarifying this. I am absolutely open to tweaking this proposal (moving it to a different module, disabling it by default, etc.) My biggest concern is to upstream this functionality so that others can use it. I stuck it in `modernize` but would absolutely be happy to move it somewhere else.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142123/new/

https://reviews.llvm.org/D142123



More information about the cfe-commits mailing list