[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 10:24:56 PST 2023


lebedev.ri added a comment.

In D142123#4066351 <https://reviews.llvm.org/D142123#4066351>, @njames93 wrote:

> Given the fact its non-standard, it has caveats and peoples eagerness to blindly enable all checks (or all checks from a module). 
> I feel this check would likely cause more harm than good.

Shall we remove abseil checks?
Shall we remove libc++-specific checks?
Shall we remove webkit checks?
Shall we remove backwards-compatibility checks?

Nothing is ever useful for everyone. Much like `-Weverything`,
enabling all checks comes with an explcit caveat that
one needs to disable the checks that are not applicable for the codebase.

+1 to having this check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142123/new/

https://reviews.llvm.org/D142123



More information about the cfe-commits mailing list