[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified
Caleb Zulawski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 19 06:06:54 PST 2023
calebzulawski added a comment.
I don't think we necessarily need to revert due to the xcrun quirk since I think it's harmless, though I can provide a follow up change if necessary. I just checked Rust's source as a comparison and it appears that for macOS targets it will always attempt to invoke xcrun regardless of host as well. I could see a macOS cross-compiler environment providing an xcrun replacement, for example. The test failures are another issue but I still don't quite understand the cause.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136315/new/
https://reviews.llvm.org/D136315
More information about the cfe-commits
mailing list