[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

You should also add a release note for the changes.



================
Comment at: clang/lib/Sema/SemaOverload.cpp:10920
 
-  // If we can fix the conversion, suggest the FixIts.
-  for (std::vector<FixItHint>::iterator HI = Cand->Fix.Hints.begin(),
-       HE = Cand->Fix.Hints.end(); HI != HE; ++HI)
-    FDiag << *HI;
+  // Check that location of Fn is not in system header (rdar://100890960).
+  if (!S.SourceMgr.isInSystemHeader(Fn->getLocation())) {
----------------
Let's drop the rdar link as that's not helpful for anyone outside of Apple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141868/new/

https://reviews.llvm.org/D141868