[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

[J. Ryan Stinnett via Phabricator via cfe-commits]

jryans added a comment.

@calebzulawski The toolchain is selected based on the target, see Driver::getToolChain <https://github.com/llvm/llvm-project/blob/3d70f3c7889e4df95fd216d66b7721617bed942f/clang/lib/Driver/Driver.cpp#L5970>.

Various groups do target macOS from Linux hosts. I'm not quite sure how the SDK is meant to be found in such a case though... @thakis, your log seems like it passes `SDKROOT`, so is that meant to be what's used for this host and target combo?

Let me know if I can assist by reverting the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136315/new/

https://reviews.llvm.org/D136315